The preview panel worked by proxying a dev server through OpenChamber's own origin and rewriting the HTML that came back. Anything the rewriter did not anticipate broke, and pages that refuse to be embedded never loaded at all. This deletes the proxy (-1604 lines and its tests) and merges the preview and browser panels into one surface backed by a real Chromium view. What the panel is now - A `<webview>` in its own session partition: logins and cookies persist, hot reload works because nothing is rewritten, DevTools are one click away. - Annotation: pick one element, drag a region, or draw freehand, write a note, and it reaches chat with a screenshot of the visible page with the marks on it. - Toolbar: hard reload, page zoom, device sizes, a light/dark switch that applies to the page rather than the app, and cookie/cache clearing scoped to the panel alone. - Several pages at once, each tab showing the page's own favicon, and an address bar that suggests pages already visited in this project. - Dev servers are listed from what is actually listening on the machine, checked against what a project announced, so a server is offered no matter how it was started. One that is still starting is waited for instead of failing. Remote dev servers The desktop app binds a local port and pipes raw bytes to the OpenChamber host over the existing authenticated connection, so the page keeps its own origin at the root of its own host. The reachable set is exactly what discovery reports and is re-checked per connection, so an authenticated client cannot dial arbitrary local services on the host. Links and redirects to another loopback port stay on the machine that served the page. A tunnel that cannot be opened is reported; it is never replaced by the plain loopback URL, which would answer from the user's own machine under a remote address. Agent control Browser actions are a separate `openchamber_web` tool: open, snapshot, click, type, scroll, inspect computed styles, resize between mobile/tablet/desktop, and capture a screenshot into `.openchamber/screenshots/` in the project. The existing `openchamber` tool keeps sessions, worktrees and scheduled tasks. Each has its own setting in the new Settings -> General -> OpenChamber Tools section, and the plugin is not injected at all when both are off. Capability belongs to the connected client, not to configuration: a client declares on its event stream that it can drive a page, which only a Chromium host does. Exactly one client performs each request — it claims the request before acting, and the first claim wins — because deciding by whose result arrives first would be too late for a click that already happened. No client listening is answered immediately with an explanation rather than a timeout. Runtime boundaries Web tabs get a plain iframe that can display a page but not inspect one. The VS Code extension no longer offers the surface at all, since nothing that makes the panel worth having works there. Mobile is unaffected. Native boundary Camera, microphone, location and device-picker requests from panel pages are denied — Electron grants them by default when no handler is set, and the panel loads whatever address the user types. Page capture, appearance emulation and storage clearing verify that their target belongs to the panel's own session instead of trusting a web-contents id from the renderer. Persisted state Stored `preview` tabs migrate to `browser` (v13 -> v14). Context panel tab limits are now per surface, so filling one surface no longer evicts another's tabs. Address history is stored per project and per runtime. Documentation `preview.mdx` and `desktop-browser.mdx` rewritten across all locales, the agent tool settings path corrected, new `DOCUMENTATION.md` for the browser-control broker and the dev tunnel, and the `ui-api-decoupling` skill updated where it still described the deleted proxy.
190 lines
6.6 KiB
JavaScript
190 lines
6.6 KiB
JavaScript
/**
|
|
* Raw byte tunnel to a dev server running on the OpenChamber host.
|
|
*
|
|
* This is what lets a desktop client preview a dev server that lives on another
|
|
* machine without rewriting anything. The client binds its own local port and
|
|
* pipes it here; the page is then served from a real origin at the root of its
|
|
* own host, so absolute URLs, cookies, HMR sockets, and DevTools all behave
|
|
* exactly as they do locally. No HTML is inspected or modified.
|
|
*
|
|
* Security posture: the reachable set is the same list dev-server discovery
|
|
* offers the user, not "any loopback port". Without that restriction an
|
|
* authenticated client could dial arbitrary local services on the host —
|
|
* databases, admin panels, the OpenCode API — through this socket.
|
|
*
|
|
* Authentication differs from the browser-facing sockets on purpose. Those
|
|
* demand an allowed `Origin`, which is a CSRF defence: a hostile page can make
|
|
* a browser open a WebSocket carrying the user's ambient cookies, and the
|
|
* origin is what exposes it. This tunnel's client is the desktop shell, not a
|
|
* browser, and it authenticates with an explicit bearer token. So:
|
|
*
|
|
* - With an `Origin` header, the request came from a browser context and the
|
|
* usual origin check applies unchanged.
|
|
* - With no `Origin`, the request must carry client-token auth. A browser
|
|
* cannot reach this path: the WebSocket API always sends an origin and never
|
|
* lets a page set an `Authorization` header.
|
|
*/
|
|
import net from 'node:net';
|
|
import { WebSocketServer } from 'ws';
|
|
|
|
const DEV_TUNNEL_WS_PATH = '/api/dev-tunnel';
|
|
/** One page load opens many sockets; the cap is per host, not per page. */
|
|
const MAX_CONCURRENT_SOCKETS = 64;
|
|
const CONNECT_TIMEOUT_MS = 5_000;
|
|
|
|
const parseRequestedPort = (url) => {
|
|
try {
|
|
const parsed = new URL(String(url || ''), 'http://localhost');
|
|
if (parsed.pathname !== DEV_TUNNEL_WS_PATH) return null;
|
|
const port = Number.parseInt(parsed.searchParams.get('port') || '', 10);
|
|
return Number.isInteger(port) && port > 0 && port <= 65535 ? port : null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
};
|
|
|
|
export const isDevTunnelPath = (url) => {
|
|
try {
|
|
return new URL(String(url || ''), 'http://localhost').pathname === DEV_TUNNEL_WS_PATH;
|
|
} catch {
|
|
return false;
|
|
}
|
|
};
|
|
|
|
export function createDevTunnelRuntime({
|
|
server,
|
|
discoverDevServers,
|
|
uiAuthController,
|
|
isRequestOriginAllowed,
|
|
rejectWebSocketUpgrade,
|
|
logger = console,
|
|
}) {
|
|
const wsServer = new WebSocketServer({ noServer: true });
|
|
let openSockets = 0;
|
|
|
|
/**
|
|
* A port is reachable only while discovery still reports it. Re-checked on
|
|
* every upgrade rather than cached, so a dev server that stops listening
|
|
* stops being reachable.
|
|
*/
|
|
const isAllowedPort = async (port) => {
|
|
const result = await discoverDevServers();
|
|
if (!result?.ok) return false;
|
|
return result.servers.some((entry) => entry.port === port);
|
|
};
|
|
|
|
wsServer.on('connection', (socket, req) => {
|
|
const port = parseRequestedPort(req.url);
|
|
if (port === null) {
|
|
socket.close(1008, 'Invalid port');
|
|
return;
|
|
}
|
|
|
|
openSockets += 1;
|
|
const upstream = net.connect({ host: '127.0.0.1', port });
|
|
upstream.setNoDelay(true);
|
|
|
|
let settled = false;
|
|
const teardown = () => {
|
|
if (settled) return;
|
|
settled = true;
|
|
openSockets -= 1;
|
|
try { upstream.destroy(); } catch { /* already gone */ }
|
|
try { socket.close(); } catch { /* already closing */ }
|
|
};
|
|
|
|
const connectTimer = setTimeout(() => {
|
|
if (!upstream.connecting) return;
|
|
logger.warn?.(`[dev-tunnel] timed out connecting to 127.0.0.1:${port}`);
|
|
teardown();
|
|
}, CONNECT_TIMEOUT_MS);
|
|
|
|
upstream.on('connect', () => clearTimeout(connectTimer));
|
|
upstream.on('data', (chunk) => {
|
|
if (socket.readyState !== socket.OPEN) return;
|
|
socket.send(chunk);
|
|
// Stop reading from the dev server while the socket drains, otherwise a
|
|
// fast response against a slow client buffers the whole body in memory.
|
|
if (socket.bufferedAmount > 1_000_000) {
|
|
upstream.pause();
|
|
const resume = () => {
|
|
if (socket.bufferedAmount > 1_000_000) {
|
|
setTimeout(resume, 20);
|
|
return;
|
|
}
|
|
upstream.resume();
|
|
};
|
|
setTimeout(resume, 20);
|
|
}
|
|
});
|
|
upstream.on('error', () => { clearTimeout(connectTimer); teardown(); });
|
|
upstream.on('close', () => { clearTimeout(connectTimer); teardown(); });
|
|
|
|
socket.on('message', (data) => {
|
|
if (upstream.destroyed) return;
|
|
upstream.write(data);
|
|
});
|
|
socket.on('close', teardown);
|
|
socket.on('error', teardown);
|
|
});
|
|
|
|
const upgradeHandler = (req, socket, head) => {
|
|
if (!isDevTunnelPath(req.url)) return;
|
|
void (async () => {
|
|
try {
|
|
if (uiAuthController?.enabled) {
|
|
const auth = await uiAuthController.resolveAuthContext(req, null, { allowUrlToken: false });
|
|
if (!auth) {
|
|
rejectWebSocketUpgrade(socket, 401, 'UI authentication required');
|
|
return;
|
|
}
|
|
const hasOrigin = typeof req.headers?.origin === 'string' && req.headers.origin.trim() !== '';
|
|
if (hasOrigin) {
|
|
if (!await isRequestOriginAllowed(req)) {
|
|
rejectWebSocketUpgrade(socket, 403, 'Invalid origin');
|
|
return;
|
|
}
|
|
} else if (auth.type !== 'client') {
|
|
rejectWebSocketUpgrade(socket, 403, 'Client authentication required');
|
|
return;
|
|
}
|
|
}
|
|
|
|
const port = parseRequestedPort(req.url);
|
|
if (port === null) {
|
|
rejectWebSocketUpgrade(socket, 400, 'Invalid port');
|
|
return;
|
|
}
|
|
if (openSockets >= MAX_CONCURRENT_SOCKETS) {
|
|
rejectWebSocketUpgrade(socket, 503, 'Too many tunnel connections');
|
|
return;
|
|
}
|
|
if (!await isAllowedPort(port)) {
|
|
// Says which port, because the alternative is an empty response in
|
|
// the panel with nothing anywhere explaining why.
|
|
logger.warn?.(`[dev-tunnel] refused port ${port}: not reported by dev-server discovery`);
|
|
rejectWebSocketUpgrade(socket, 403, 'That port is not an available dev server');
|
|
return;
|
|
}
|
|
|
|
wsServer.handleUpgrade(req, socket, head, (ws) => wsServer.emit('connection', ws, req));
|
|
} catch {
|
|
rejectWebSocketUpgrade(socket, 500, 'Upgrade failed');
|
|
}
|
|
})();
|
|
};
|
|
|
|
server.on('upgrade', upgradeHandler);
|
|
|
|
return {
|
|
path: DEV_TUNNEL_WS_PATH,
|
|
get openSocketCount() {
|
|
return openSockets;
|
|
},
|
|
dispose() {
|
|
server.off('upgrade', upgradeHandler);
|
|
wsServer.close();
|
|
},
|
|
};
|
|
}
|