Files
openchamber/packages/web/server/lib/opencode/session-runtime.test.js
T
Serhii Dziupin 14d7a0ca9b fix: settle busy sessions after managed OpenCode restart (#3002)
* fix: reconcile busy sessions after managed OpenCode restart

Forced health-check restarts previously rebound the event stream without
settling in-flight turns, so sessions stayed busy with no terminal state.
Interrupt those sessions, classify health failures, and retain bounded
process diagnostics for post-restart diagnosis.

Fixes #2943

Co-authored-by: serkraser <serkraser@gmail.com>

* fix: surface interrupted chats after OpenCode restart

Complete unfinished assistant turns as aborted once the session is
authoritatively idle, and show a persistent toast so users can continue
instead of remaining silently stranded.

Fixes #2943

Co-authored-by: serkraser <serkraser@gmail.com>

* fix: redact Basic auth credentials in restart diagnostics

The key/value sanitizer stopped at whitespace, so Authorization: Basic
credentials survived in stderr tails and health snapshots. Redact the
scheme token before that rule runs.

Co-authored-by: serkraser <serkraser@gmail.com>
2026-08-19 11:53:30 +03:00

306 lines
9.0 KiB
JavaScript

import { afterEach, describe, expect, it, vi } from 'vitest';
import { createSessionRuntime } from './session-runtime.js';
describe('session runtime', () => {
const runtimes = [];
afterEach(() => {
for (const runtime of runtimes) {
runtime.dispose();
}
runtimes.length = 0;
});
it('broadcasts attention clears through the shared broadcaster', () => {
const events = [];
const runtime = createSessionRuntime({
writeSseEvent() {
throw new Error('SSE fallback should not be used when broadcastEvent is provided');
},
getNotificationClients: () => new Set(),
broadcastEvent: (payload) => {
events.push(payload);
},
});
runtimes.push(runtime);
runtime.processOpenCodeSsePayload({
type: 'session.status',
properties: {
sessionID: 'session-1',
status: {
type: 'busy',
},
},
});
runtime.markUserMessageSent('session-1');
runtime.processOpenCodeSsePayload({
type: 'session.status',
properties: {
sessionID: 'session-1',
status: {
type: 'idle',
},
},
});
runtime.markSessionViewed('session-1', 'client-1');
expect(events).toContainEqual({
type: 'openchamber:session-status',
properties: expect.objectContaining({
sessionID: 'session-1',
status: 'idle',
needsAttention: true,
}),
});
expect(events.at(-1)).toEqual({
type: 'openchamber:session-status',
properties: {
sessionID: 'session-1',
status: 'idle',
timestamp: expect.any(Number),
metadata: {},
needsAttention: false,
},
});
});
it('accepts legacy session.status info.type payloads', () => {
const events = [];
const runtime = createSessionRuntime({
writeSseEvent() {
throw new Error('SSE fallback should not be used when broadcastEvent is provided');
},
getNotificationClients: () => new Set(),
broadcastEvent: (payload) => {
events.push(payload);
},
});
runtimes.push(runtime);
runtime.processOpenCodeSsePayload({
type: 'session.status',
properties: {
sessionID: 'legacy-session-1',
info: {
type: 'busy',
},
},
});
expect(events).toContainEqual({
type: 'openchamber:session-status',
properties: expect.objectContaining({
sessionID: 'legacy-session-1',
status: 'busy',
}),
});
});
it('broadcasts idle activity when cooldown expires', () => {
vi.useFakeTimers();
const events = [];
const runtime = createSessionRuntime({
writeSseEvent() {
throw new Error('SSE fallback should not be used when broadcastEvent is provided');
},
getNotificationClients: () => new Set(),
broadcastEvent: (payload) => {
events.push(payload);
},
});
try {
runtime.processOpenCodeSsePayload({
type: 'session.status',
properties: {
sessionID: 'session-activity-1',
status: {
type: 'busy',
},
},
});
runtime.processOpenCodeSsePayload({
type: 'session.status',
properties: {
sessionID: 'session-activity-1',
status: {
type: 'idle',
},
},
});
const activityPhases = () => events
.filter((event) => event.type === 'openchamber:session-activity')
.map((event) => event.properties.phase);
expect(activityPhases()).toEqual(['busy', 'cooldown']);
vi.advanceTimersByTime(1999);
expect(activityPhases()).toEqual(['busy', 'cooldown']);
vi.advanceTimersByTime(1);
expect(activityPhases()).toEqual(['busy', 'cooldown', 'idle']);
} finally {
runtime.dispose();
vi.useRealTimers();
}
});
it('maintains an idempotent active session count', () => {
const runtime = createSessionRuntime({
writeSseEvent() {},
getNotificationClients: () => new Set(),
broadcastEvent() {},
});
runtimes.push(runtime);
const status = (sessionID, type) => runtime.processOpenCodeSsePayload({
type: 'session.status',
properties: { sessionID, status: { type } },
});
expect(runtime.getActiveSessionCount()).toBe(0);
status('session-1', 'busy');
status('session-1', 'busy');
status('session-1', 'retry');
expect(runtime.getActiveSessionCount()).toBe(1);
status('session-2', 'busy');
expect(runtime.getActiveSessionCount()).toBe(2);
status('session-1', 'idle');
expect(runtime.getActiveSessionCount()).toBe(1);
status('session-1', 'idle');
expect(runtime.getActiveSessionCount()).toBe(1);
runtime.resetAllSessionActivityToIdle();
expect(runtime.getActiveSessionCount()).toBe(0);
});
it('interrupts busy sessions after restart and broadcasts terminal events once', () => {
const events = [];
const runtime = createSessionRuntime({
writeSseEvent() {},
getNotificationClients: () => new Set(),
broadcastEvent: (event) => events.push(event),
});
runtimes.push(runtime);
const status = (sessionID, type) => runtime.processOpenCodeSsePayload({
type: 'session.status',
properties: { sessionID, status: { type } },
});
status('session-busy-1', 'busy');
status('session-busy-2', 'retry');
status('session-busy-3', 'busy');
status('session-idle', 'idle');
expect(runtime.getActiveSessionCount()).toBe(3);
events.length = 0;
expect(runtime.interruptBusySessionsAfterRestart()).toEqual({
sessionIds: ['session-busy-1', 'session-busy-2', 'session-busy-3'],
});
expect(runtime.getActiveSessionCount()).toBe(0);
expect(runtime.getSessionActivitySnapshot()).toEqual({
'session-busy-1': { type: 'idle' },
'session-busy-2': { type: 'idle' },
'session-busy-3': { type: 'idle' },
'session-idle': { type: 'idle' },
});
expect(runtime.getSessionStateSnapshot()).toEqual({
'session-busy-1': expect.objectContaining({
status: 'idle',
metadata: expect.objectContaining({
message: 'Interrupted by OpenCode restart',
reason: 'opencode-restart',
}),
}),
'session-busy-2': expect.objectContaining({ status: 'idle' }),
'session-busy-3': expect.objectContaining({ status: 'idle' }),
'session-idle': expect.objectContaining({ status: 'idle' }),
});
const terminalEvents = events.filter((event) => (
event.type === 'openchamber:session-status' || event.type === 'session.error'
));
expect(terminalEvents).toHaveLength(6);
for (const sessionId of ['session-busy-1', 'session-busy-2', 'session-busy-3']) {
expect(terminalEvents).toContainEqual({
type: 'openchamber:session-status',
properties: expect.objectContaining({
sessionID: sessionId,
status: 'idle',
}),
});
expect(terminalEvents).toContainEqual({
type: 'session.error',
properties: {
sessionID: sessionId,
error: {
name: 'MessageAbortedError',
message: 'The running turn was interrupted when OpenCode restarted.',
},
},
});
}
expect(terminalEvents.some((event) => event.properties.sessionID === 'session-idle')).toBe(false);
events.length = 0;
expect(runtime.interruptBusySessionsAfterRestart()).toEqual({ sessionIds: [] });
expect(events).toEqual([]);
});
it('restores activity when busy interrupts cooldown without timer underflow', () => {
vi.useFakeTimers();
const runtime = createSessionRuntime({
writeSseEvent() {},
getNotificationClients: () => new Set(),
broadcastEvent() {},
});
const status = (type) => runtime.processOpenCodeSsePayload({
type: 'session.status',
properties: { sessionID: 'session-1', status: { type } },
});
try {
status('busy');
status('idle');
expect(runtime.getActiveSessionCount()).toBe(0);
status('retry');
expect(runtime.getActiveSessionCount()).toBe(1);
vi.advanceTimersByTime(2000);
expect(runtime.getActiveSessionCount()).toBe(1);
expect(runtime.getSessionActivitySnapshot()['session-1']).toEqual({ type: 'busy' });
} finally {
runtime.dispose();
vi.useRealTimers();
}
});
it('releases retained session state when disposed', () => {
const runtime = createSessionRuntime({
writeSseEvent() {},
getNotificationClients: () => new Set(),
broadcastEvent() {},
});
runtimes.push(runtime);
runtime.processOpenCodeSsePayload({
type: 'session.status',
properties: { sessionID: 'session-1', status: { type: 'busy' } },
});
runtime.markUserMessageSent('session-1');
runtime.dispose();
expect(runtime.getActiveSessionCount()).toBe(0);
expect(runtime.getSessionActivitySnapshot()).toEqual({});
expect(runtime.getSessionStateSnapshot()).toEqual({});
expect(runtime.getSessionAttentionSnapshot()).toEqual({});
});
});