Files
openchamber/packages/ui/src/lib/scheduledTasksApi.ts
T
Serhii DziupinandSerhii Dziupin e99f6560be fix(scheduled-tasks): prevent dual-server double dispatch of daily tasks (#2713)
* fix(scheduled-tasks): claim schedule occurrences across server instances

Two OpenChamber servers sharing project config each armed timers and both
dispatched the same daily/weekly/cron/once slot (#2710). Claim the occurrence
in shared config under a cross-process write lock before creating a session.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* fix(scheduled-tasks): harden occurrence claim failure and lock ownership

Address PR review blockers: release running-slot bookkeeping when claim
throws, avoid silently dropping an armed occurrence after a due-slack sync,
verify lock-file ownership on release, and cover real on-disk lock behavior.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* fix(scheduled-tasks): always release running slot on state-write failures

Wrap runTask bookkeeping in finally so claim, manual-start, and completion
lock timeouts cannot stuck-run a task; drop the diskNext claim guard that
suppressed later occurrences; recover unparseable locks via mtime age.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* fix(scheduled-tasks): stop re-arming past nextRunAt and clear stuck running

Only schedule future nextRunAt values so once-task losers and claim-failed
paths cannot spin delay-0 retries. Clear past once nextRunAt on claim, and on
completion-write failure retry terminal status so manual runNow still returns
the session instead of a hard 500 with lastStatus stuck running.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* fix(scheduled-tasks): release write chain on lock acquire timeout

withProjectWriteLock left the in-process promise chain pending when
acquireProjectFileLock timed out, wedging every later project write and
stranding runTask before finally. Always release the chain; surface
persistError on run; record once claim failures in task state.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

---------

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>
2026-08-13 16:14:42 +03:00

169 lines
5.6 KiB
TypeScript

import { runtimeFetch } from './runtime-fetch';
export type ScheduledTaskStatus = 'idle' | 'running' | 'success' | 'error';
export type ScheduledTask = {
id: string;
name: string;
enabled: boolean;
/** Absolute path of the `.agents/loops/*.md` file driving this task, when
* any. Present only for loop-sourced tasks; unknown to older clients. */
loopFile?: string;
schedule: {
kind: 'daily' | 'weekly' | 'once' | 'cron';
times?: string[];
time?: string;
date?: string;
weekdays?: number[];
cron?: string;
timezone?: string;
};
execution: {
prompt: string;
providerID: string;
modelID: string;
variant?: string;
agent?: string;
goalEnabled?: boolean;
goalTokenBudget?: number;
permissionAutoAccept?: boolean;
};
state: {
createdAt: number;
updatedAt: number;
lastRunAt?: number;
lastStatus?: ScheduledTaskStatus;
lastError?: string;
lastDurationMs?: number;
lastSessionId?: string;
nextRunAt?: number;
};
};
const parseErrorMessage = async (response: Response, fallback: string) => {
try {
const parsed = await response.json();
if (parsed && typeof parsed.error === 'string' && parsed.error.trim().length > 0) {
return parsed.error;
}
} catch {
return fallback;
}
return fallback;
};
const ensureProjectID = (projectID: string): string => {
const trimmed = typeof projectID === 'string' ? projectID.trim() : '';
if (!trimmed) {
throw new Error('projectId is required');
}
return trimmed;
};
export const fetchScheduledTasks = async (projectID: string): Promise<ScheduledTask[]> => {
const safeProjectID = ensureProjectID(projectID);
const response = await runtimeFetch(`/api/projects/${encodeURIComponent(safeProjectID)}/scheduled-tasks`);
if (!response.ok) {
throw new Error(await parseErrorMessage(response, 'Failed to load scheduled tasks'));
}
const parsed = await response.json().catch(() => null);
if (!parsed || !Array.isArray(parsed.tasks)) {
return [];
}
return parsed.tasks as ScheduledTask[];
};
export const upsertScheduledTask = async (projectID: string, task: Partial<ScheduledTask>): Promise<ScheduledTask[]> => {
const safeProjectID = ensureProjectID(projectID);
const response = await runtimeFetch(`/api/projects/${encodeURIComponent(safeProjectID)}/scheduled-tasks`, {
method: 'PUT',
headers: {
'content-type': 'application/json',
accept: 'application/json',
},
body: JSON.stringify({ task }),
});
if (!response.ok) {
throw new Error(await parseErrorMessage(response, 'Failed to save scheduled task'));
}
const parsed = await response.json().catch(() => null);
if (!parsed || !Array.isArray(parsed.tasks)) {
return [];
}
return parsed.tasks as ScheduledTask[];
};
export const deleteScheduledTask = async (projectID: string, taskID: string): Promise<ScheduledTask[]> => {
const safeProjectID = ensureProjectID(projectID);
const safeTaskID = ensureProjectID(taskID);
const response = await runtimeFetch(`/api/projects/${encodeURIComponent(safeProjectID)}/scheduled-tasks/${encodeURIComponent(safeTaskID)}`, {
method: 'DELETE',
headers: {
accept: 'application/json',
},
});
if (!response.ok) {
throw new Error(await parseErrorMessage(response, 'Failed to delete scheduled task'));
}
const parsed = await response.json().catch(() => null);
if (!parsed || !Array.isArray(parsed.tasks)) {
return [];
}
return parsed.tasks as ScheduledTask[];
};
const getLoopFileEndpoint = (projectID: string, taskID: string): string => {
const safeProjectID = ensureProjectID(projectID);
const safeTaskID = ensureProjectID(taskID);
return `/api/projects/${encodeURIComponent(safeProjectID)}/scheduled-tasks/${encodeURIComponent(safeTaskID)}/loop-file`;
};
export const setLoopScheduledTaskEnabled = async (projectID: string, taskID: string, enabled: boolean): Promise<void> => {
const response = await runtimeFetch(getLoopFileEndpoint(projectID, taskID), {
method: 'PATCH',
headers: { 'content-type': 'application/json', accept: 'application/json' },
body: JSON.stringify({ enabled }),
});
if (!response.ok) {
throw new Error(await parseErrorMessage(response, 'Failed to update loop task'));
}
};
export const deleteScheduledTaskLoopFile = async (projectID: string, taskID: string): Promise<void> => {
const response = await runtimeFetch(getLoopFileEndpoint(projectID, taskID), {
method: 'DELETE',
headers: { accept: 'application/json' },
});
if (!response.ok) {
throw new Error(await parseErrorMessage(response, 'Failed to delete loop file'));
}
};
export const syncScheduledTaskLoops = async (projectID: string): Promise<void> => {
await fetchScheduledTasks(projectID);
};
export const runScheduledTaskNow = async (
projectID: string,
taskID: string,
): Promise<{ sessionId?: string; persistError?: string }> => {
const safeProjectID = ensureProjectID(projectID);
const safeTaskID = ensureProjectID(taskID);
const response = await runtimeFetch(`/api/projects/${encodeURIComponent(safeProjectID)}/scheduled-tasks/${encodeURIComponent(safeTaskID)}/run`, {
method: 'POST',
headers: {
accept: 'application/json',
},
});
if (!response.ok) {
throw new Error(await parseErrorMessage(response, 'Failed to run scheduled task'));
}
const parsed = await response.json().catch(() => null);
return {
sessionId: typeof parsed?.sessionId === 'string' && parsed.sessionId.length > 0 ? parsed.sessionId : undefined,
persistError: typeof parsed?.persistError === 'string' && parsed.persistError.trim().length > 0
? parsed.persistError.trim()
: undefined,
};
};