Bohdan Triapitsyn
a5aa32446d
The preview panel worked by proxying a dev server through OpenChamber's own origin and rewriting the HTML that came back. Anything the rewriter did not anticipate broke, and pages that refuse to be embedded never loaded at all. This deletes the proxy (-1604 lines and its tests) and merges the preview and browser panels into one surface backed by a real Chromium view. What the panel is now - A `<webview>` in its own session partition: logins and cookies persist, hot reload works because nothing is rewritten, DevTools are one click away. - Annotation: pick one element, drag a region, or draw freehand, write a note, and it reaches chat with a screenshot of the visible page with the marks on it. - Toolbar: hard reload, page zoom, device sizes, a light/dark switch that applies to the page rather than the app, and cookie/cache clearing scoped to the panel alone. - Several pages at once, each tab showing the page's own favicon, and an address bar that suggests pages already visited in this project. - Dev servers are listed from what is actually listening on the machine, checked against what a project announced, so a server is offered no matter how it was started. One that is still starting is waited for instead of failing. Remote dev servers The desktop app binds a local port and pipes raw bytes to the OpenChamber host over the existing authenticated connection, so the page keeps its own origin at the root of its own host. The reachable set is exactly what discovery reports and is re-checked per connection, so an authenticated client cannot dial arbitrary local services on the host. Links and redirects to another loopback port stay on the machine that served the page. A tunnel that cannot be opened is reported; it is never replaced by the plain loopback URL, which would answer from the user's own machine under a remote address. Agent control Browser actions are a separate `openchamber_web` tool: open, snapshot, click, type, scroll, inspect computed styles, resize between mobile/tablet/desktop, and capture a screenshot into `.openchamber/screenshots/` in the project. The existing `openchamber` tool keeps sessions, worktrees and scheduled tasks. Each has its own setting in the new Settings -> General -> OpenChamber Tools section, and the plugin is not injected at all when both are off. Capability belongs to the connected client, not to configuration: a client declares on its event stream that it can drive a page, which only a Chromium host does. Exactly one client performs each request — it claims the request before acting, and the first claim wins — because deciding by whose result arrives first would be too late for a click that already happened. No client listening is answered immediately with an explanation rather than a timeout. Runtime boundaries Web tabs get a plain iframe that can display a page but not inspect one. The VS Code extension no longer offers the surface at all, since nothing that makes the panel worth having works there. Mobile is unaffected. Native boundary Camera, microphone, location and device-picker requests from panel pages are denied — Electron grants them by default when no handler is set, and the panel loads whatever address the user types. Page capture, appearance emulation and storage clearing verify that their target belongs to the panel's own session instead of trusting a web-contents id from the renderer. Persisted state Stored `preview` tabs migrate to `browser` (v13 -> v14). Context panel tab limits are now per surface, so filling one surface no longer evicts another's tabs. Address history is stored per project and per runtime. Documentation `preview.mdx` and `desktop-browser.mdx` rewritten across all locales, the agent tool settings path corrected, new `DOCUMENTATION.md` for the browser-control broker and the dev tunnel, and the `ui-api-decoupling` skill updated where it still described the deleted proxy.
63 lines
2.2 KiB
TypeScript
63 lines
2.2 KiB
TypeScript
import { create } from 'zustand';
|
|
|
|
import { invokeDesktopCommand } from '@/lib/desktopNative';
|
|
|
|
/**
|
|
* Page icons for browser tabs, kept per origin.
|
|
*
|
|
* Per origin rather than per tab or per page: a site uses one icon everywhere,
|
|
* so the second tab on the same host already has its icon, and navigating
|
|
* within a site does not make the tab flicker back to a placeholder.
|
|
*
|
|
* Held in memory only. The icons are data URLs, and filling persisted storage
|
|
* with them to save one small request per host is a poor trade.
|
|
*/
|
|
const MAX_ORIGINS = 60;
|
|
|
|
type FaviconState = {
|
|
byOrigin: Record<string, string>;
|
|
/** Resolves and stores the icon a page reported. Failure is silent by design. */
|
|
resolve: (pageUrl: string, iconUrl: string) => void;
|
|
};
|
|
|
|
const originOf = (value: string): string => {
|
|
try {
|
|
return new URL(value).origin;
|
|
} catch {
|
|
return '';
|
|
}
|
|
};
|
|
|
|
/** Requests in flight, so a page reporting its icon twice fetches once. */
|
|
const pending = new Set<string>();
|
|
|
|
export const useBrowserFaviconStore = create<FaviconState>()((set, get) => ({
|
|
byOrigin: {},
|
|
|
|
resolve: (pageUrl, iconUrl) => {
|
|
const origin = originOf(pageUrl);
|
|
if (!origin || !iconUrl) return;
|
|
if (get().byOrigin[origin] || pending.has(origin)) return;
|
|
|
|
pending.add(origin);
|
|
void invokeDesktopCommand<{ dataUrl?: string }>('desktop_browser_fetch_favicon', { url: iconUrl })
|
|
.then((result) => {
|
|
const dataUrl = typeof result?.dataUrl === 'string' ? result.dataUrl : '';
|
|
if (!dataUrl) return;
|
|
set((state) => {
|
|
const byOrigin = { ...state.byOrigin, [origin]: dataUrl };
|
|
const origins = Object.keys(byOrigin);
|
|
if (origins.length <= MAX_ORIGINS) return { byOrigin };
|
|
// Oldest first: insertion order is close enough to least-recently-seen
|
|
// for a cache whose only cost is one request.
|
|
for (const stale of origins.slice(0, origins.length - MAX_ORIGINS)) delete byOrigin[stale];
|
|
return { byOrigin };
|
|
});
|
|
})
|
|
// A missing or unreachable icon is not a problem worth reporting: the tab
|
|
// simply keeps the placeholder it already has.
|
|
.catch(() => undefined)
|
|
.finally(() => { pending.delete(origin); });
|
|
},
|
|
}));
|