feat(sections): refactor section dialog for edit/delete, add dropdown menu in project detail

apps/web/app/(dashboard)/projects/[id]/page.tsx

@@ -2,10 +2,26 @@
 
 import { useState, useEffect, useCallback } from "react";
 import { useParams } from "next/navigation";
-import { Plus, ArrowLeft, GripVertical, MoreHorizontal } from "lucide-react";
+import { Plus, ArrowLeft, GripVertical, MoreHorizontal, Pencil, Trash2 } from "lucide-react";
 import { Button } from "@/components/ui/button";
 import { Badge } from "@/components/ui/badge";
 import { Progress } from "@/components/ui/progress";
+import {
+  DropdownMenu,
+  DropdownMenuContent,
+  DropdownMenuItem,
+  DropdownMenuTrigger,
+} from "@/components/ui/dropdown-menu";
+import {
+  AlertDialog,
+  AlertDialogAction,
+  AlertDialogCancel,
+  AlertDialogContent,
+  AlertDialogDescription,
+  AlertDialogFooter,
+  AlertDialogHeader,
+  AlertDialogTitle,
+} from "@/components/ui/alert-dialog";
 import { SectionDialog } from "@/components/projects/section-dialog";
 import Link from "next/link";
 import { toast } from "sonner";
@@ -65,6 +81,9 @@ export default function ProjectDetailPage() {
   const [domainId, setDomainId] = useState<string | null>(null);
   const [loading, setLoading] = useState(true);
   const [sectionDialogOpen, setSectionDialogOpen] = useState(false);
+  const [editSection, setEditSection] = useState<Section | null>(null);
+  const [deleteSection, setDeleteSection] = useState<Section | null>(null);
+  const [deletingSection, setDeletingSection] = useState(false);
   const [draggedTaskId, setDraggedTaskId] = useState<string | null>(null);
 
   // Extract domainId from the project data
@@ -239,9 +258,31 @@ export default function ProjectDetailPage() {
                   <Badge variant="outline" className="text-xs">Milestone</Badge>
                 )}
               </div>
-              <span className="text-xs text-muted-foreground">
-                {(tasksBySection.get(section.id) || []).length}
-              </span>
+              <div className="flex items-center gap-1">
+                <span className="text-xs text-muted-foreground">
+                  {(tasksBySection.get(section.id) || []).length}
+                </span>
+                <DropdownMenu>
+                  <DropdownMenuTrigger asChild>
+                    <button
+                      className="rounded-md p-1 text-muted-foreground hover:text-foreground hover:bg-accent transition-colors"
+                      aria-label={`Options for ${section.name}`}
+                    >
+                      <MoreHorizontal className="h-3.5 w-3.5" />
+                    </button>
+                  </DropdownMenuTrigger>
+                  <DropdownMenuContent align="end">
+                    <DropdownMenuItem onClick={() => setEditSection(section)}>
+                      <Pencil className="mr-2 h-4 w-4" />
+                      Edit
+                    </DropdownMenuItem>
+                    <DropdownMenuItem onClick={() => setDeleteSection(section)}>
+                      <Trash2 className="mr-2 h-4 w-4" />
+                      Delete
+                    </DropdownMenuItem>
+                  </DropdownMenuContent>
+                </DropdownMenu>
+              </div>
             </div>
             <div
               className="space-y-2 min-h-[100px]"
@@ -297,6 +338,53 @@ export default function ProjectDetailPage() {
         domainId={domainId || ''}
         onCreated={fetchProject}
       />
+
+      {editSection && (
+        <SectionDialog
+          open={!!editSection}
+          onOpenChange={(open) => { if (!open) setEditSection(null); }}
+          projectId={projectId}
+          domainId={domainId || ''}
+          onCreated={fetchProject}
+          existingSection={editSection}
+        />
+      )}
+
+      <AlertDialog open={!!deleteSection} onOpenChange={(open) => { if (!open) setDeleteSection(null); }}>
+        <AlertDialogContent>
+          <AlertDialogHeader>
+            <AlertDialogTitle>Delete Section</AlertDialogTitle>
+            <AlertDialogDescription>
+              Are you sure you want to delete &quot;{deleteSection?.name}&quot;? This action cannot be undone. Tasks in this section will become unassigned.
+            </AlertDialogDescription>
+          </AlertDialogHeader>
+          <AlertDialogFooter>
+            <AlertDialogCancel>Cancel</AlertDialogCancel>
+            <AlertDialogAction
+              disabled={deletingSection}
+              onClick={async () => {
+                if (!deleteSection || !domainId) return;
+                setDeletingSection(true);
+                try {
+                  const res = await fetch(`/api/domains/${domainId}/projects/${projectId}/sections/${deleteSection.id}`, {
+                    method: 'DELETE',
+                  });
+                  if (!res.ok) throw new Error('Failed to delete');
+                  toast.success('Section deleted');
+                  setDeleteSection(null);
+                  fetchProject();
+                } catch {
+                  toast.error('Failed to delete section');
+                } finally {
+                  setDeletingSection(false);
+                }
+              }}
+            >
+              {deletingSection ? 'Deleting...' : 'Delete'}
+            </AlertDialogAction>
+          </AlertDialogFooter>
+        </AlertDialogContent>
+      </AlertDialog>
     </div>
   );
 }

apps/web/app/(dashboard)/projects/page.tsx

@@ -188,7 +188,6 @@ export default function ProjectsPage() {
                     </div>
                   )}
                 </CardContent>
-              </Card>
                 </Card>
               </Link>
               <div className="absolute right-2 top-2">

apps/web/components/projects/section-dialog.tsx

@@ -10,6 +10,16 @@ import {
   DialogHeader,
   DialogTitle,
 } from '@/components/ui/dialog';
+import {
+  AlertDialog,
+  AlertDialogAction,
+  AlertDialogCancel,
+  AlertDialogContent,
+  AlertDialogDescription,
+  AlertDialogFooter,
+  AlertDialogHeader,
+  AlertDialogTitle,
+} from '@/components/ui/alert-dialog';
 import { Input } from '@/components/ui/input';
 import { Label } from '@/components/ui/label';
 import {
@@ -21,12 +31,23 @@ import {
 } from '@/components/ui/select';
 import { toast } from 'sonner';
 
+interface Section {
+  id: string;
+  name: string;
+  projectId: string;
+  kind: 'section' | 'milestone';
+  status: 'planned' | 'in_progress' | 'complete';
+  targetDate: string | null;
+  sortOrder: number;
+}
+
 interface SectionDialogProps {
   open: boolean;
   onOpenChange: (open: boolean) => void;
   projectId: string;
   domainId: string;
   onCreated: () => void;
+  existingSection?: Section;
 }
 
 export function SectionDialog({
@@ -35,23 +56,34 @@ export function SectionDialog({
   projectId,
   domainId,
   onCreated,
+  existingSection,
 }: SectionDialogProps) {
+  const isEdit = !!existingSection;
   const [name, setName] = useState('');
   const [kind, setKind] = useState<'section' | 'milestone'>('section');
   const [status, setStatus] = useState<'planned' | 'in_progress' | 'complete'>('planned');
   const [targetDate, setTargetDate] = useState('');
   const [submitting, setSubmitting] = useState(false);
   const [error, setError] = useState('');
+  const [deleteOpen, setDeleteOpen] = useState(false);
+  const [deleting, setDeleting] = useState(false);
 
   useEffect(() => {
     if (open) {
-      setName('');
-      setKind('section');
-      setStatus('planned');
-      setTargetDate('');
+      if (existingSection) {
+        setName(existingSection.name);
+        setKind(existingSection.kind);
+        setStatus(existingSection.status);
+        setTargetDate(existingSection.targetDate ? existingSection.targetDate.split('T')[0] : '');
+      } else {
+        setName('');
+        setKind('section');
+        setStatus('planned');
+        setTargetDate('');
+      }
       setError('');
     }
-  }, [open]);
+  }, [open, existingSection]);
 
   async function handleSubmit(event: React.FormEvent<HTMLFormElement>) {
     event.preventDefault();
@@ -66,98 +98,164 @@ export function SectionDialog({
     if (targetDate) body.targetDate = new Date(targetDate).toISOString();
 
     try {
-      const response = await fetch(`/api/domains/${domainId}/projects/${projectId}/sections`, {
-        method: 'POST',
-        headers: { 'Content-Type': 'application/json' },
-        body: JSON.stringify(body),
-      });
+      let response: Response;
+
+      if (isEdit && existingSection) {
+        response = await fetch(`/api/domains/${domainId}/projects/${projectId}/sections/${existingSection.id}`, {
+          method: 'PATCH',
+          headers: { 'Content-Type': 'application/json' },
+          body: JSON.stringify(body),
+        });
+      } else {
+        response = await fetch(`/api/domains/${domainId}/projects/${projectId}/sections`, {
+          method: 'POST',
+          headers: { 'Content-Type': 'application/json' },
+          body: JSON.stringify(body),
+        });
+      }
 
       if (!response.ok) {
         const err = await response.json();
-        throw new Error(err.error?.message || 'Unable to create section');
+        throw new Error(err.error?.message || `Unable to ${isEdit ? 'update' : 'create'} section`);
       }
 
-      toast.success('Section created');
+      toast.success(isEdit ? 'Section updated' : 'Section created');
       onOpenChange(false);
       onCreated();
     } catch (err) {
-      setError(err instanceof Error ? err.message : 'Unable to create section');
+      setError(err instanceof Error ? err.message : `Unable to ${isEdit ? 'update' : 'create'} section`);
     } finally {
       setSubmitting(false);
     }
   }
 
+  async function handleDelete() {
+    if (!existingSection) return;
+    setDeleting(true);
+    try {
+      const response = await fetch(`/api/domains/${domainId}/projects/${projectId}/sections/${existingSection.id}`, {
+        method: 'DELETE',
+      });
+
+      if (!response.ok) {
+        const err = await response.json();
+        throw new Error(err.error?.message || 'Unable to delete section');
+      }
+
+      toast.success('Section deleted');
+      setDeleteOpen(false);
+      onOpenChange(false);
+      onCreated();
+    } catch (err) {
+      toast.error(err instanceof Error ? err.message : 'Unable to delete section');
+    } finally {
+      setDeleting(false);
+    }
+  }
+
   return (
-    <Dialog open={open} onOpenChange={onOpenChange}>
-      <DialogContent className="sm:max-w-[450px]">
-        <DialogHeader>
-          <DialogTitle>New Section</DialogTitle>
-          <DialogDescription>Add a section or milestone to organize tasks.</DialogDescription>
-        </DialogHeader>
-        <form className="space-y-4" onSubmit={handleSubmit}>
-          <div className="space-y-2">
-            <Label htmlFor="section-name">Name *</Label>
-            <Input
-              id="section-name"
-              value={name}
-              onChange={(e) => setName(e.target.value)}
-              placeholder="e.g. Backend, Design, Launch"
-              autoFocus
-              required
-            />
-          </div>
-
-          <div className="grid grid-cols-2 gap-4">
+    <>
+      <Dialog open={open} onOpenChange={onOpenChange}>
+        <DialogContent className="sm:max-w-[450px]">
+          <DialogHeader>
+            <DialogTitle>{isEdit ? 'Edit Section' : 'New Section'}</DialogTitle>
+            <DialogDescription>
+              {isEdit ? 'Update this section or milestone.' : 'Add a section or milestone to organize tasks.'}
+            </DialogDescription>
+          </DialogHeader>
+          <form className="space-y-4" onSubmit={handleSubmit}>
             <div className="space-y-2">
-              <Label htmlFor="section-kind">Kind</Label>
-              <Select value={kind} onValueChange={(v) => setKind(v as any)}>
-                <SelectTrigger id="section-kind">
-                  <SelectValue />
-                </SelectTrigger>
-                <SelectContent>
-                  <SelectItem value="section">Section</SelectItem>
-                  <SelectItem value="milestone">Milestone</SelectItem>
-                </SelectContent>
-              </Select>
+              <Label htmlFor="section-name">Name *</Label>
+              <Input
+                id="section-name"
+                value={name}
+                onChange={(e) => setName(e.target.value)}
+                placeholder="e.g. Backend, Design, Launch"
+                autoFocus
+                required
+              />
+            </div>
+
+            <div className="grid grid-cols-2 gap-4">
+              <div className="space-y-2">
+                <Label htmlFor="section-kind">Kind</Label>
+                <Select value={kind} onValueChange={(v) => setKind(v as any)}>
+                  <SelectTrigger id="section-kind">
+                    <SelectValue />
+                  </SelectTrigger>
+                  <SelectContent>
+                    <SelectItem value="section">Section</SelectItem>
+                    <SelectItem value="milestone">Milestone</SelectItem>
+                  </SelectContent>
+                </Select>
+              </div>
+
+              <div className="space-y-2">
+                <Label htmlFor="section-status">Status</Label>
+                <Select value={status} onValueChange={(v) => setStatus(v as any)}>
+                  <SelectTrigger id="section-status">
+                    <SelectValue />
+                  </SelectTrigger>
+                  <SelectContent>
+                    <SelectItem value="planned">Planned</SelectItem>
+                    <SelectItem value="in_progress">In Progress</SelectItem>
+                    <SelectItem value="complete">Complete</SelectItem>
+                  </SelectContent>
+                </Select>
+              </div>
             </div>
 
             <div className="space-y-2">
-              <Label htmlFor="section-status">Status</Label>
-              <Select value={status} onValueChange={(v) => setStatus(v as any)}>
-                <SelectTrigger id="section-status">
-                  <SelectValue />
-                </SelectTrigger>
-                <SelectContent>
-                  <SelectItem value="planned">Planned</SelectItem>
-                  <SelectItem value="in_progress">In Progress</SelectItem>
-                  <SelectItem value="complete">Complete</SelectItem>
-                </SelectContent>
-              </Select>
+              <Label htmlFor="section-target-date">Target date</Label>
+              <Input
+                id="section-target-date"
+                type="date"
+                value={targetDate}
+                onChange={(e) => setTargetDate(e.target.value)}
+              />
             </div>
-          </div>
 
-          <div className="space-y-2">
-            <Label htmlFor="section-target-date">Target date</Label>
-            <Input
-              id="section-target-date"
-              type="date"
-              value={targetDate}
-              onChange={(e) => setTargetDate(e.target.value)}
-            />
-          </div>
+            {error && <p className="text-sm text-destructive" role="alert">{error}</p>}
 
-          {error && <p className="text-sm text-destructive" role="alert">{error}</p>}
+            <DialogFooter className="flex items-center justify-between sm:justify-between">
+              {isEdit && (
+                <Button
+                  type="button"
+                  variant="destructive"
+                  onClick={() => setDeleteOpen(true)}
+                >
+                  Delete
+                </Button>
+              )}
+              <div className="flex gap-2">
+                <Button type="button" variant="outline" onClick={() => onOpenChange(false)}>
+                  Cancel
+                </Button>
+                <Button type="submit" disabled={submitting || !name}>
+                  {submitting ? (isEdit ? 'Saving...' : 'Creating...') : (isEdit ? 'Save' : 'Create Section')}
+                </Button>
+              </div>
+            </DialogFooter>
+          </form>
+        </DialogContent>
+      </Dialog>
 
-          <DialogFooter>
-            <Button type="button" variant="outline" onClick={() => onOpenChange(false)}>
-              Cancel
-            </Button>
-            <Button type="submit" disabled={submitting || !name}>
-              {submitting ? 'Creating...' : 'Create Section'}
-            </Button>
-          </DialogFooter>
-        </form>
-      </DialogContent>
-    </Dialog>
+      <AlertDialog open={deleteOpen} onOpenChange={setDeleteOpen}>
+        <AlertDialogContent>
+          <AlertDialogHeader>
+            <AlertDialogTitle>Delete Section</AlertDialogTitle>
+            <AlertDialogDescription>
+              Are you sure you want to delete &quot;{existingSection?.name}&quot;? This action cannot be undone.
+            </AlertDialogDescription>
+          </AlertDialogHeader>
+          <AlertDialogFooter>
+            <AlertDialogCancel>Cancel</AlertDialogCancel>
+            <AlertDialogAction onClick={handleDelete} disabled={deleting}>
+              {deleting ? 'Deleting...' : 'Delete'}
+            </AlertDialogAction>
+          </AlertDialogFooter>
+        </AlertDialogContent>
+      </AlertDialog>
+    </>
   );
 }