fix(tasks): guard loop name length and surface loop ownership in the UI

Review follow-up:

- Reject loop files whose frontmatter name exceeds MAX_TASK_NAME_LENGTH
  (80): task names are clamped at storage time, so a raw name longer than
  the limit could never match the stored task identity. The file is treated
  as malformed (definition: null) instead of creating an unreachable
  definition; MAX_TASK_NAME_LENGTH is now exported from project-config.js
  and shared with loops.js.
- Surface loop-sourced tasks in the scheduled-tasks dialog: tasks carrying
  loopFile show a 'Managed by loop file <path>' note, and the enable
  toggle / edit / delete actions are disabled with an explanatory tooltip,
  since the file remains authoritative and would revert any such change.
  run-now stays available. New locale keys added to all 11 message files
  (i18n parity test enforces exact key sets).
- ScheduledTask type gains an optional loopFile field (additive, unknown
  to older clients).
This commit is contained in:
makeittech
2026-08-06 09:38:18 +03:00
parent 359225d363
commit 59a6c1b70d
17 changed files with 96 additions and 7 deletions
@@ -181,6 +181,33 @@ model: openai/gpt-5
await cleanup();
}
});
it('rejects names longer than the storage limit', async () => {
const { projectPath, cleanup } = await createProject();
try {
const warn = vi.spyOn(console, 'warn').mockImplementation(() => undefined);
try {
const filePath = path.join(projectPath, 'long-name.md');
await writeFile(filePath, `---
name: ${'x'.repeat(81)}
schedule: "0 9 * * *"
model: openai/gpt-5
---
Run.
`, 'utf8');
// Task names are clamped to 80 chars at storage time; a raw name that
// exceeds it could never match the stored task, so the file is treated
// as malformed rather than creating an unreachable definition.
expect(parseLoopDefinition(filePath)).toBeNull();
expect(warn).toHaveBeenCalled();
} finally {
warn.mockRestore();
}
} finally {
await cleanup();
}
});
});
describe('discoverLoops', () => {