BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: restore typing in branch dropdown search fields

Browse Source 
Prevent menu typeahead from intercepting search input keystrokes
Fix branch search in worktree and Git sidebar dropdowns
Cover related directory tree and integrate branch inputs
This commit is contained in:
Bohdan Triapitsyn
2026-05-17 23:48:05 +03:00
parent 622927c34c
commit 5c1333a139
4 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/session/DirectoryTree.tsx
+2 -4
View File
@@ -815,13 +815,12 @@ export const DirectoryTree: React.FC<DirectoryTreeProps> = ({
value={newDirName}
onChange={(e) => setNewDirName(e.target.value)}
onKeyDown={(e) => {
e.stopPropagation();
if (e.key === 'Enter') {
e.preventDefault();
e.stopPropagation();
createDirectory();
} else if (e.key === 'Escape') {
e.preventDefault();
e.stopPropagation();
cancelCreatingDirectory();
}
}}
@@ -904,13 +903,12 @@ export const DirectoryTree: React.FC<DirectoryTreeProps> = ({
value={newDirName}
onChange={(e) => setNewDirName(e.target.value)}
onKeyDown={(e) => {
e.stopPropagation();
if (e.key === 'Enter') {
e.preventDefault();
e.stopPropagation();
createDirectory();
} else if (e.key === 'Escape') {
e.preventDefault();
e.stopPropagation();
cancelCreatingDirectory();
}
}}
packages/ui/src/components/session/NewWorktreeDialog.tsx
+6
View File
@@ -299,6 +299,10 @@ export function NewWorktreeDialog({
const existingBranchMobileListWrapperRef = React.useRef<HTMLDivElement | null>(null);
const sourceBranchMobileListWrapperRef = React.useRef<HTMLDivElement | null>(null);
const stopDropdownTypeahead = React.useCallback((event: React.KeyboardEvent<HTMLInputElement>) => {
event.stopPropagation();
}, []);
const findScrollableContainer = React.useCallback((startNode: HTMLElement | null): HTMLElement | null => {
let node: HTMLElement | null = startNode;
while (node && node !== document.body) {
@@ -1600,6 +1604,7 @@ export function NewWorktreeDialog({
placeholder={t('session.newWorktree.searchBranches')}
value={existingBranchQuery}
onValueChange={setExistingBranchQuery}
onKeyDown={stopDropdownTypeahead}
/>
<CommandList disableHorizontal>
{isLoadingBranches ? (
@@ -1840,6 +1845,7 @@ export function NewWorktreeDialog({
placeholder={t('session.newWorktree.searchBranches')}
value={sourceBranchQuery}
onValueChange={setSourceBranchQuery}
onKeyDown={stopDropdownTypeahead}
/>
<CommandList disableHorizontal>
{isLoadingBranches ? (
packages/ui/src/components/views/git/BranchSelector.tsx
+1
View File
@@ -189,6 +189,7 @@ export const BranchSelector: React.FC<BranchSelectorProps> = ({
placeholder={t('gitView.branch.searchPlaceholder')}
value={search}
onValueChange={setSearch}
onKeyDown={stopDropdownTypeahead}
/>
<CommandList
scrollbarClassName="overlay-scrollbar--flush overlay-scrollbar--dense overlay-scrollbar--zero"
packages/ui/src/components/views/git/IntegrateCommitsSection.tsx
+5 -1
View File
@@ -383,7 +383,11 @@ export const IntegrateCommitsSection: React.FC<{
className="w-72 p-0 max-h-[var(--available-height)] flex flex-col overflow-hidden"
>
<Command className="h-full min-h-0">
<CommandInput ref={searchInputRef} placeholder={t('gitView.branch.searchPlaceholder')} />
<CommandInput
ref={searchInputRef}
placeholder={t('gitView.branch.searchPlaceholder')}
onKeyDown={(event) => event.stopPropagation()}
/>
<CommandList
className="h-full min-h-0"
scrollbarClassName="overlay-scrollbar--flush overlay-scrollbar--dense overlay-scrollbar--zero"