fix(pwa): keep scoped shortcuts isolated (#1205)

Co-authored-by: Isaac Sanchez <isanchez-hawkins@arize.com>
2026-05-12 10:55:31 +03:00
parent c38727efc9
commit 733e1e2d21
2 changed files with 81 additions and 1 deletions
@@ -130,7 +130,7 @@ export const registerPwaManifestRoute = (app, dependencies) => {
        } else {
          const globalPayload = await listSessions(null);
          const filteredGlobalPayload = filterSessionsByDirectory(globalPayload, preferredDirectory);
-          payload = filteredGlobalPayload.length > 0 ? filteredGlobalPayload : globalPayload;
+          payload = filteredGlobalPayload;
        }
      } else {
        payload = await listSessions(null);
@@ -0,0 +1,80 @@
+import { describe, expect, it } from 'vitest';
+import { registerPwaManifestRoute } from './pwa-manifest-routes.js';
+
+const createResponse = () => ({
+  headers: new Map(),
+  contentType: '',
+  body: '',
+  setHeader(name, value) {
+    this.headers.set(name, value);
+    return this;
+  },
+  type(value) {
+    this.contentType = value;
+    return this;
+  },
+  send(value) {
+    this.body = value;
+    return this;
+  },
+});
+
+describe('PWA manifest route', () => {
+  it('does not fall back to unrelated global session shortcuts for scoped manifests', async () => {
+    const routes = new Map();
+    const app = {
+      get(route, handler) {
+        routes.set(route, handler);
+      },
+    };
+    const originalFetch = globalThis.fetch;
+    const fetchCalls = [];
+    globalThis.fetch = async (url) => {
+      fetchCalls.push(String(url));
+      const sessions = String(url).includes('?directory=')
+        ? []
+        : [
+            {
+              id: 'other-session',
+              title: 'Other project',
+              directory: '/workspace/other',
+              time: { updated: 2 },
+            },
+          ];
+      return {
+        ok: true,
+        json: async () => sessions,
+      };
+    };
+
+    try {
+      registerPwaManifestRoute(app, {
+        process: { platform: 'darwin' },
+        resolveProjectDirectory: async () => ({ directory: '/workspace/app' }),
+        buildOpenCodeUrl: (route) => route,
+        getOpenCodeAuthHeaders: () => ({}),
+        readSettingsFromDiskMigrated: async () => ({}),
+        normalizePwaAppName: (value, fallback) => typeof value === 'string' && value.trim() ? value.trim() : fallback,
+        normalizePwaOrientation: (value, fallback) => typeof value === 'string' && value.trim() ? value.trim() : fallback,
+      });
+
+      const handler = routes.get('/manifest.webmanifest');
+      const res = createResponse();
+      await handler({ query: {} }, res);
+
+      const manifest = JSON.parse(res.body);
+      expect(fetchCalls).toHaveLength(2);
+      expect(manifest.shortcuts).toEqual([
+        {
+          name: 'Appearance Settings',
+          short_name: 'Settings',
+          description: 'Open appearance settings',
+          url: '/?settings=appearance',
+          icons: [{ src: '/pwa-192.png', sizes: '192x192', type: 'image/png' }],
+        },
+      ]);
+    } finally {
+      globalThis.fetch = originalFetch;
+    }
+  });
+});