BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(github): show an Open settings button in not-connected dialogs for quick access

Browse Source
This commit is contained in:
Bohdan Triapitsyn
2026-01-24 02:15:16 +02:00
parent f370ea5d8c
commit ab8a613f9a
5 changed files with 52 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/sections/openchamber/OpenChamberPage.tsx
+4 -1
View File
@@ -10,7 +10,7 @@ import { NotificationSettings } from './NotificationSettings';
import { GitHubSettings } from './GitHubSettings';
import { ScrollableOverlay } from '@/components/ui/ScrollableOverlay';
import { useDeviceInfo } from '@/lib/device';
import { isWebRuntime } from '@/lib/desktop';
import { isVSCodeRuntime, isWebRuntime } from '@/lib/desktop';
import type { OpenChamberSection } from './OpenChamberSidebar';
interface OpenChamberPageProps {
@@ -122,6 +122,9 @@ const GitSectionContent: React.FC = () => {
// GitHub section: Connect account for PR/issue workflows
const GitHubSectionContent: React.FC = () => {
if (isVSCodeRuntime()) {
return null;
}
return <GitHubSettings />;
};
packages/ui/src/components/sections/openchamber/OpenChamberSidebar.tsx
+1
View File
@@ -46,6 +46,7 @@ const OPENCHAMBER_SECTION_GROUPS: SectionGroup[] = [
id: 'github',
label: 'GitHub',
items: ['Connect', 'PRs', 'Issues'],
hideInVSCode: true,
},
{
id: 'notifications',
packages/ui/src/components/session/GitHubIssuePickerDialog.tsx
+16 -1
View File
@@ -24,6 +24,7 @@ import { useSessionStore } from '@/stores/useSessionStore';
import { useConfigStore } from '@/stores/useConfigStore';
import { useMessageStore } from '@/stores/messageStore';
import { useContextStore } from '@/stores/contextStore';
import { useUIStore } from '@/stores/useUIStore';
import { opencodeClient } from '@/lib/opencode/client';
import { createWorktreeSessionForNewBranch } from '@/lib/worktreeSessionCreator';
import { generateBranchSlug } from '@/lib/git/branchNameGenerator';
@@ -69,6 +70,8 @@ export function GitHubIssuePickerDialog({
onOpenChange: (open: boolean) => void;
}) {
const { github } = useRuntimeAPIs();
const setSettingsDialogOpen = useUIStore((state) => state.setSettingsDialogOpen);
const setSidebarSection = useUIStore((state) => state.setSidebarSection);
const activeProject = useProjectsStore((state) => state.getActiveProject());
const projectDirectory = activeProject?.path ?? null;
@@ -156,6 +159,11 @@ export function GitHubIssuePickerDialog({
const connected = Boolean(result?.connected);
const repoUrl = result?.repo?.url ?? null;
const openGitHubSettings = React.useCallback(() => {
setSidebarSection('settings');
setSettingsDialogOpen(true);
}, [setSettingsDialogOpen, setSidebarSection]);
const filtered = React.useMemo(() => {
const q = query.trim().toLowerCase();
if (!q) return issues;
@@ -458,7 +466,14 @@ Do not implement changes until I confirm; end with: “Next actions: <1 sentence
) : null}
{connected === false ? (
<div className="text-center text-muted-foreground py-8">GitHub not connected.</div>
<div className="text-center text-muted-foreground py-8 space-y-3">
<div>GitHub not connected. Connect your GitHub account in settings.</div>
<div className="flex justify-center">
<Button variant="outline" size="sm" onClick={openGitHubSettings}>
Open settings
</Button>
</div>
</div>
) : null}
{error ? (
packages/ui/src/components/session/GitHubPullRequestPickerDialog.tsx
+16 -1
View File
@@ -24,6 +24,7 @@ import { useSessionStore } from '@/stores/useSessionStore';
import { useConfigStore } from '@/stores/useConfigStore';
import { useMessageStore } from '@/stores/messageStore';
import { useContextStore } from '@/stores/contextStore';
import { useUIStore } from '@/stores/useUIStore';
import { opencodeClient } from '@/lib/opencode/client';
import { createWorktreeSessionForNewBranchExact } from '@/lib/worktreeSessionCreator';
import { gitFetch } from '@/lib/gitApi';
@@ -60,6 +61,8 @@ export function GitHubPullRequestPickerDialog({
onOpenChange: (open: boolean) => void;
}) {
const { github } = useRuntimeAPIs();
const setSettingsDialogOpen = useUIStore((state) => state.setSettingsDialogOpen);
const setSidebarSection = useUIStore((state) => state.setSidebarSection);
const activeProject = useProjectsStore((state) => state.getActiveProject());
const projectDirectory = activeProject?.path ?? null;
@@ -148,6 +151,11 @@ export function GitHubPullRequestPickerDialog({
const connected = Boolean(result?.connected);
const repoUrl = result?.repo?.url ?? null;
const openGitHubSettings = React.useCallback(() => {
setSidebarSection('settings');
setSettingsDialogOpen(true);
}, [setSettingsDialogOpen, setSidebarSection]);
const filtered = React.useMemo(() => {
const q = query.trim().toLowerCase();
if (!q) return prs;
@@ -468,7 +476,14 @@ Nice-to-have:
) : null}
{connected === false ? (
<div className="text-center text-muted-foreground py-8">GitHub not connected.</div>
<div className="text-center text-muted-foreground py-8 space-y-3">
<div>GitHub not connected. Connect your GitHub account in settings.</div>
<div className="flex justify-center">
<Button variant="outline" size="sm" onClick={openGitHubSettings}>
Open settings
</Button>
</div>
</div>
) : null}
{error ? (
packages/ui/src/components/views/git/PullRequestSection.tsx
+15 -2
View File
@@ -18,6 +18,7 @@ import {
} from '@/components/ui/collapsible';
import { generatePullRequestDescription } from '@/lib/gitApi';
import { useRuntimeAPIs } from '@/hooks/useRuntimeAPIs';
import { useUIStore } from '@/stores/useUIStore';
import type {
GitHubPullRequest,
GitHubPullRequestStatus,
@@ -73,6 +74,13 @@ export const PullRequestSection: React.FC<{
baseBranch: string;
}> = ({ directory, branch, baseBranch }) => {
const { github } = useRuntimeAPIs();
const setSettingsDialogOpen = useUIStore((state) => state.setSettingsDialogOpen);
const setSidebarSection = useUIStore((state) => state.setSidebarSection);
const openGitHubSettings = React.useCallback(() => {
setSidebarSection('settings');
setSettingsDialogOpen(true);
}, [setSettingsDialogOpen, setSidebarSection]);
const [isOpen, setIsOpen] = React.useState(true);
const [isLoading, setIsLoading] = React.useState(false);
@@ -263,8 +271,13 @@ export const PullRequestSection: React.FC<{
<div className="border-t border-border/40">
<div className="flex flex-col gap-3 p-3">
{!isConnected ? (
<div className="typography-meta text-muted-foreground">
GitHub not connected. Connect in Settings to create and merge PRs.
<div className="space-y-2">
<div className="typography-meta text-muted-foreground">
GitHub not connected. Connect your GitHub account in settings.
</div>
<Button variant="outline" size="sm" onClick={openGitHubSettings} className="w-fit">
Open settings
</Button>
</div>
) : null}