perf: reduce chat rerenders during streaming

Stabilizes unchanged chat turns while messages stream
Keeps static chat history from rerendering unnecessarily
Adds coverage for turn record reuse
This commit is contained in:
Bohdan Triapitsyn
2026-05-27 14:01:25 +03:00
parent 27255c642d
commit cfd13544bd
4 changed files with 113 additions and 12 deletions
+18 -10
View File
@@ -19,6 +19,9 @@ import { normalizeParts } from './message/partUtils';
const MESSAGE_LIST_VIRTUALIZE_THRESHOLD = 5;
const MESSAGE_LIST_OVERSCAN = 6;
const EMPTY_STATIC_ENTRY_MESSAGES: ChatMessageEntry[] = [];
const EMPTY_UNGROUPED_MESSAGE_IDS = new Set<string>();
const EMPTY_VIRTUAL_ROWS: VirtualItem[] = [];
const estimateHistoryEntryHeight = (entry: RenderEntry | undefined): number => {
if (!entry) {
@@ -936,7 +939,7 @@ const MessageListEntry = React.memo(({
MessageListEntry.displayName = 'MessageListEntry';
// Inner component that renders staged turn entries.
const StaticHistoryList: React.FC<{
type StaticHistoryListProps = {
entries: RenderEntry[];
shouldVirtualize: boolean;
virtualRows: VirtualItem[];
@@ -954,7 +957,9 @@ const StaticHistoryList: React.FC<{
shouldAnimateUserMessage: (message: ChatMessageEntry) => boolean;
onUserAnimationConsumed: (messageId: string) => void;
activeStreamingPhase?: StreamPhase | null;
}> = ({ entries, shouldVirtualize, virtualRows, totalSize, measureElement, contentRef, onMessageContentChange, getAnimationHandlers, scrollToBottom, stickyUserHeader, defaultActivityExpanded, turnUiStates, onToggleTurnGroup, chatRenderMode, shouldAnimateUserMessage, onUserAnimationConsumed, activeStreamingPhase }) => {
};
const StaticHistoryList = React.memo(({ entries, shouldVirtualize, virtualRows, totalSize, measureElement, contentRef, onMessageContentChange, getAnimationHandlers, scrollToBottom, stickyUserHeader, defaultActivityExpanded, turnUiStates, onToggleTurnGroup, chatRenderMode, shouldAnimateUserMessage, onUserAnimationConsumed, activeStreamingPhase }: StaticHistoryListProps) => {
const renderEntry = React.useCallback((entry: RenderEntry) => {
return (
<MessageListEntry
@@ -1043,7 +1048,7 @@ const StaticHistoryList: React.FC<{
{paddingBottom > 0 ? <div aria-hidden="true" style={{ height: `${paddingBottom}px` }} /> : null}
</div>
);
};
});
StaticHistoryList.displayName = 'StaticHistoryList';
@@ -1222,6 +1227,9 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
sessionKey,
showTextJustificationActivity: chatRenderMode === 'sorted',
});
const hasUngroupedStaticEntries = projection.ungroupedMessageIds.size > 0;
const staticEntryMessages = hasUngroupedStaticEntries ? displayMessages : EMPTY_STATIC_ENTRY_MESSAGES;
const staticEntryUngroupedIds = hasUngroupedStaticEntries ? projection.ungroupedMessageIds : EMPTY_UNGROUPED_MESSAGE_IDS;
const staticRenderEntries = React.useMemo<RenderEntry[]>(() => streamPerfMeasure('ui.message_list.render_entries_ms', () => {
const turnEntries = staticTurns.map((turn) => ({
kind: 'turn' as const,
@@ -1230,7 +1238,7 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
isLastTurn: turn.turnId === projection.lastTurnId,
}));
if (projection.ungroupedMessageIds.size === 0) {
if (staticEntryUngroupedIds.size === 0) {
return turnEntries;
}
@@ -1240,14 +1248,14 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
});
const orderedEntries: RenderEntry[] = [];
displayMessages.forEach((message, index) => {
staticEntryMessages.forEach((message, index) => {
const turnEntry = turnEntryByUserMessageId.get(message.info.id);
if (turnEntry) {
orderedEntries.push(turnEntry);
return;
}
if (!projection.ungroupedMessageIds.has(message.info.id)) {
if (!staticEntryUngroupedIds.has(message.info.id)) {
return;
}
@@ -1255,13 +1263,13 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
kind: 'ungrouped',
key: `msg:${message.info.id}`,
message,
previousMessage: index > 0 ? displayMessages[index - 1] : undefined,
nextMessage: index < displayMessages.length - 1 ? displayMessages[index + 1] : undefined,
previousMessage: index > 0 ? staticEntryMessages[index - 1] : undefined,
nextMessage: index < staticEntryMessages.length - 1 ? staticEntryMessages[index + 1] : undefined,
});
});
return orderedEntries;
}), [displayMessages, projection.lastTurnId, projection.ungroupedMessageIds, staticTurns]);
}), [projection.lastTurnId, staticEntryMessages, staticEntryUngroupedIds, staticTurns]);
const trailingStreamingEntry = React.useMemo<RenderEntry | undefined>(() => {
if (streamingTurn) {
@@ -1428,7 +1436,7 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
}, []);
const historyVirtualRows = React.useMemo(
() => (shouldVirtualizeHistory ? historyVirtualizer.getVirtualItems() : []),
() => (shouldVirtualizeHistory ? historyVirtualizer.getVirtualItems() : EMPTY_VIRTUAL_ROWS),
[historyVirtualizer, shouldVirtualizeHistory],
);
@@ -22,9 +22,14 @@ export const useTurnRecords = (
const staticTurnsRef = React.useRef<TurnRecord[]>([]);
const streamingTurnRef = React.useRef<TurnRecord | undefined>(undefined);
const previousSessionKeyRef = React.useRef<string | undefined>(options.sessionKey);
const previousShowTextJustificationActivityRef = React.useRef(options.showTextJustificationActivity);
if (previousSessionKeyRef.current !== options.sessionKey) {
if (
previousSessionKeyRef.current !== options.sessionKey
|| previousShowTextJustificationActivityRef.current !== options.showTextJustificationActivity
) {
previousSessionKeyRef.current = options.sessionKey;
previousShowTextJustificationActivityRef.current = options.showTextJustificationActivity;
previousProjectionRef.current = null;
staticTurnsRef.current = [];
streamingTurnRef.current = undefined;
@@ -86,4 +86,36 @@ describe('projectTurnRecords', () => {
expect(projection.turns).toHaveLength(0);
expect(projection.ungroupedMessageIds.has('s1')).toBe(true);
});
test('reuses unchanged turn records from the previous projection', () => {
const user1 = createMessageEntry({ id: 'u1', role: 'user', createdAt: 1 });
const assistant1 = createMessageEntry({ id: 'a1', role: 'assistant', parentID: 'u1', createdAt: 2 });
const user2 = createMessageEntry({ id: 'u2', role: 'user', createdAt: 3 });
const assistant2 = createMessageEntry({ id: 'a2', role: 'assistant', parentID: 'u2', createdAt: 4 });
const initial = projectTurnRecords([user1, assistant1, user2, assistant2]);
const updatedAssistant2 = {
...assistant2,
parts: [{ type: 'text', text: 'stream update' } as Part],
};
const next = projectTurnRecords([user1, assistant1, user2, updatedAssistant2], {
previousProjection: initial,
});
expect(next.turns[0]).toBe(initial.turns[0]);
expect(next.turns[1]).not.toBe(initial.turns[1]);
});
test('reuses the whole turns array when every turn is unchanged', () => {
const user = createMessageEntry({ id: 'u1', role: 'user', createdAt: 1 });
const assistant = createMessageEntry({ id: 'a1', role: 'assistant', parentID: 'u1', createdAt: 2 });
const initial = projectTurnRecords([user, assistant]);
const next = projectTurnRecords([user, assistant], {
previousProjection: initial,
});
expect(next.turns).toBe(initial.turns);
expect(next.turns[0]).toBe(initial.turns[0]);
});
});
@@ -90,6 +90,61 @@ const DEFAULT_OPTIONS: ProjectTurnRecordsOptions = {
showTextJustificationActivity: false,
};
const areSameMessageRefs = (left: ChatMessageEntry[], right: ChatMessageEntry[]): boolean => {
if (left === right) {
return true;
}
if (left.length !== right.length) {
return false;
}
for (let index = 0; index < left.length; index += 1) {
if (left[index] !== right[index]) {
return false;
}
}
return true;
};
const canReusePreviousTurn = (previous: TurnRecord, next: TurnRecord): boolean => {
return previous.userMessage === next.userMessage
&& previous.headerMessageId === next.headerMessageId
&& areSameMessageRefs(previous.assistantMessages, next.assistantMessages);
};
const stabilizeTurnRecords = (
turns: TurnRecord[],
previousProjection?: TurnProjectionResult | null,
): TurnRecord[] => {
if (!previousProjection || previousProjection.turns.length === 0 || turns.length === 0) {
return turns;
}
let canReuseTurnArray = previousProjection.turns.length === turns.length;
let reusedAnyTurn = false;
const nextTurns = turns.map((turn, index) => {
const previousTurn = previousProjection.indexes.turnById.get(turn.turnId);
if (previousTurn && canReusePreviousTurn(previousTurn, turn)) {
reusedAnyTurn = true;
if (previousProjection.turns[index] !== previousTurn) {
canReuseTurnArray = false;
}
return previousTurn;
}
canReuseTurnArray = false;
return turn;
});
if (canReuseTurnArray && reusedAnyTurn) {
return previousProjection.turns;
}
return reusedAnyTurn ? nextTurns : turns;
};
export const projectTurnRecords = (
messages: ChatMessageEntry[],
options?: Partial<ProjectTurnRecordsOptions>,
@@ -179,7 +234,8 @@ export const projectTurnRecords = (
turn.durationMs = turn.stream.durationMs;
});
const projection = projectTurnIndexes(turns);
const stableTurns = stabilizeTurnRecords(turns, effectiveOptions.previousProjection);
const projection = projectTurnIndexes(stableTurns);
const ungroupedMessageIds = new Set<string>();
messages.forEach((message) => {
if (resolveMessageRole(message) === 'assistant') {