* fix(ui): reveal overlay scrollbar on hover or active scroll (re-port to bindScrollbar)
Re-ports #2825's container-hover reveal onto the rewritten bindScrollbar
architecture that landed on main after the original PR branch was created.
- pointerenter/pointerleave on the scroll container reveal the thumb
immediately (deliberate intent on every mouse-pointer runtime; inert
on touch via an event.pointerType === 'mouse' guard, since the Pointer
Events spec fires pointerenter on touch taps as well)
- hide-timer re-checks pointerOverContainer at fire time, so the thumb does
not vanish when the pointer moves from container onto the sibling thumb
- suppressVisibility (chat auto-follow) still suppresses hover reveal
- on hover, schedule a re-measure so the horizontal thumb reflects the
current geometry: if the container has horizontal overflow the thumb is
revealed, otherwise it stays hidden. This matches the original PR's
updateMetrics() approach and avoids the regression where onScroll (which
does not measure) would leave a legitimately overflowing horizontal
thumb hidden while hovering
- index.css: drop the Settings-specific overlay-scrollbar display:none
(thumb is never permanently visible anywhere now)
- regression tests: horizontal thumb reveals on hover when overflow exists,
stays hidden when it does not; touch pointerenter is inert; hand-off
race (container pointerleave followed by thumb pointerover) keeps the
thumb visible; pointerleave hides the thumb
* ci(ui): add overlay scrollbar interaction recording workflow
Records the hover-reveal/hide interaction of the overlay scrollbar
(PR #3219 re-port to bindScrollbar) as a webm + GIF via Playwright
recordVideo, converted with ffmpeg palettegen/paletteuse.
- scripts/record-overlay-scrollbar.mjs: drives hover in/out, forces
overflow on the first .overlay-scrollbar-target so the demo works on
a clean data dir, exports overlay-scrollbar-hover.{webm,gif}.
- .github/workflows/interaction-recording.yml: mirrors the validated
screenshots.yml pattern (auth disabled server, Playwright chromium,
15-min timeout), adds ffmpeg install step.
* docs(ui): add overlay scrollbar interaction recording
Animated GIF captured by the interaction-recording workflow (Playwright
recordVideo + ffmpeg) showing the hover-reveal/hide behavior of the
re-ported overlay scrollbar (bindScrollbar): thumb fades in on pointer
enter, hides again after the hide delay once the pointer leaves.
* feat(ui): adopt ScrollableOverlay in remaining native-scroll panels
Extends the overlay scrollbar (hover-reveal, hide-on-leave) to panels
that still used native overflow-y-auto scrolling:
- Sidebar (left nav): outer flex-1 scroll region
- ContextSidebarTab: full-height tab content
- SessionSwitcherDropdown: session list dropdown (preserves contentRef
for scrollIntoView / switcher item queries)
- HelpDialog: help content region
All four merge sizing into outerClassName (flex-1 min-h-0 / h-full /
max-h-[60vh]) and keep visual classes on className, with disableHorizontal
where the original hid horizontal overflow. Type-check passes; unit test
failures in OverlayScrollbar.test.tsx and event-pipeline.test.js are
pre-existing (reproduce on pristine HEAD).
* test(ui): flush hide timer before asserting thumb hidden
The hide path always schedules a setTimeout (hideDelayMs: 0 still
schedules a 0ms timer). happy-dom runs real timers, so the test must
let the macrotask fire before asserting dataset.visible — flushing rAF
frames alone is not enough. Fixes the one failing test in
OverlayScrollbar.test.tsx (12/13 -> 13/13).
* fix(ci): make scrollbar interaction recording hover retry across targets
The record script picked the first .overlay-scrollbar-target and moved the
pointer to its center; layout/hydration order varies between CI runs, so
the hover sometimes landed on a target whose thumb cannot reveal (empty
container), failing the run. Now it iterates targets in DOM order until
the vertical thumb actually appears (or fails after exhausting all).
* fix(ci): record workflow + i18n + overlay-chrome hide
- .github/workflows/interaction-recording.yml: drop 'ref: rework' so the
workflow checks out the PR head SHA on upstream (where 'rework' branch
does not exist). Replace with persist-credentials: true.
- packages/ui/src/lib/i18n/messages/tr.ts: add 4 missing gitView.empty
keys (parity fix, only tr.ts was behind en.ts). Translations are
approximate; the parity test only checks key existence.
- scripts/record-overlay-scrollbar.mjs: on a fresh data dir the web
build can render onboarding modals (ChooserScreen, AboutDialog,
ConfigUpdateOverlay) that float above the MainLayout with a blurred
backdrop. The thumb's isThumbVisible() returns true (DOM-mounted)
but the captured frame is dominated by the modal, so the user sees
'dialog in front, blurred background' instead of the scrollbar
reveal. hideOverlayChrome() injects CSS to hide every plausible
overlay root and best-effort closes known UI store dialogs.
* fix(ci): drop fork-specific ref in record workflow + add tr locale gitView.empty keys
- .github/workflows/interaction-recording.yml: drop 'ref: rework' so the
workflow checks out the PR head SHA on upstream (where 'rework' branch
does not exist). Replace with persist-credentials: true.
- packages/ui/src/lib/i18n/messages/tr.ts: add 4 missing gitView.empty
keys (parity fix, only tr.ts was behind en.ts). Translations are
approximate; the parity test only checks key existence.
- scripts/record-overlay-scrollbar.mjs: hide onboarding chrome (modals,
backdrops, dialogs) that float above the MainLayout when recording
against a fresh data dir, so the captured GIF shows the actual
scrollbar reveal instead of a blurred-overlay dialog screen.
- docs/interaction-recordings/overlay-scrollbar-hover.gif: regenerate
(489 KB) with overlay chrome hidden (same artifact as CI run
33507731092 which passed).
* ci: noop push to retrigger 'pr checks' on a fresh runner
The 'pr checks' check on this PR's prior head (0509212c3) failed with
'releaseJob is not a function' in packages/web/server/lib/walkthrough/
routes.test.js. This test lives in upstream main and is not touched by
this PR's diff. The same flake is currently hitting PR #3265 and
feat/scheduled-preflight-gate.
Confirmed the two latest upstream main commits (bec7a82568 sidebar
sort, 40e4b6f857 request-security) do not touch walkthrough/, so the
failure is a 20ms timing flake in the test's executor Promise, not a
code regression. This empty commit triggers a new CI run on a
different runner with a different scheduling window.
* feat(settings): adopt ScrollableOverlay in settings shell and dialogs
Several settings surfaces still rendered their scroll containers with
native browser scrollbars (overflow-y-auto / overflow-y-scroll), which
read inconsistently against the overlay scrollbar used everywhere else
in the app once content exceeded the viewport.
Wrap the relevant containers in <ScrollableOverlay>:
- SettingsView: nav sidebar (mobile), mobile fallback, mobile page
sidebar, mobile page content, and desktop split view
- DirectoryExplorerDialog: results list
- GitHubIntegrationDialog: issues / PRs list
- GitHubIssuePickerDialog, GitHubPrPickerDialog: lists
- NewWorktreeDialog: form body
The settings sub-pages (OpenChamberPage, VoiceSettings, PasskeySettings,
etc.) do not carry their own overflow — they inherit the scroll host
from SettingsView, so the shell change is sufficient for them.
type-check, lint, and ui tests (368/369, the one failure is a pre-existing
event-pipeline flake unrelated to this change) all pass.
* ci(record): re-run overlay scrollbar recording on a fresh runner window
* ci(record): give overlay thumb 1500ms to reveal on hover
The 'hover did not reveal the thumb on any target' check has been
flaky across runs since the workflow landed in this branch (about
half the runs fail with the same error). 700ms was tight on cold
GitHub-hosted runners; 1500ms absorbs the cold-start variance
without changing what the GIF captures (the thumb's hide animation
runs after pointerleave, unaffected by the longer pre-leave wait).
* ci(record): debug thumb visibility timing on hover
* ci(record): drop debug logging, keep 1500ms hover wait
Debug logging was used to identify that 200ms is enough on a
healthy runner, but 700ms was not. The flake was the OpenChamber
server being slow to initialize the OpenCode side on cold
runners — the thumb itself renders quickly once the app is up.
Keeping 1500ms absorbs that cold-start variance without slowing
successful runs by more than the GIF's existing post-hover
animation wait (1000ms hideDelayMs).
---------
Co-authored-by: sergiofspedro <sergiofspedro@users.noreply.github.com>
Co-authored-by: openchamber-ops <ops@openchamber.dev>
Co-authored-by: Bohdan Triapitsyn <artmore@protonmail.com>
The netstat-based parser matched the literal English "LISTENING"
state string, which is translated on non-English Windows (e.g.
"ABHÖREN", "ÉCOUTE", "ESCUTANDO"). On those systems the regex matched
zero lines, so killProcessOnPort silently did nothing -- fail-open,
not a regression, but ineffective for the exact users the fix targets.
Replace it with `Get-NetTCPConnection -State Listen -LocalPort <port>`,
which reads the same underlying WinNT API netstat's display layer
translates, so it's unaffected by OS display language. Verified
against a real listening port on this machine (matched the actual
owning PID).
Also fixed a stale duplicate of the "killProcessOnPort is a no-op on
Windows" comment left behind in server/index.js.
killProcessOnPort() was a no-op on win32 (POSIX-only, via lsof/kill),
so a restart could leave the old OpenCode process holding the port
while a new instance spawned on a different one. That's a plausible
contributor to a chronic pattern seen in production logs: repeated
"OpenCode process exited, restarting" cycles and hundreds of
ECONNRESET/proxy errors over multiple days on Windows.
Give killProcessOnPort a real Windows branch: parse `netstat -ano`
for PIDs listening on the target port, filter out our own pid, and
force-kill each via `taskkill /PID <pid> /F` (no /T -- we don't own
that process, so only the listener itself is killed, not any
children it may have).
waitForPortRelease()'s existing soft-fail-and-warn behavior is left
untouched -- it's a deliberate safety net for any platform where the
port doesn't free up in time, not just Windows, and the restart
already rebinds event-stream readers to the actual resulting port via
onOpenCodeRestarted.
PR #2520fixed#2475 in the wrong layer (overflow classes on
SettingsView.tsx wrapper divs that aren't the actual scroll containers),
so the "no scrollbar in Settings" bug shipped in v1.17.2 unchanged, and
the sessions feed has the same underlying issue (#2402).
The actual scroll containers render through ScrollableOverlay ->
OverlayScrollbar, which hides the native scrollbar and draws its own
JS thumb that auto-hides ~1s after scroll activity stops, with a
second CSS rule fully hiding that thumb inside Settings specifically.
Fix both at the shared component/CSS layer so every consumer (Settings,
sessions feed, git panels, chat, etc.) gets a persistent scrollbar on
desktop shells (Electron + VS Code webview) in one change:
- OverlayScrollbar.tsx: skip the auto-hide timer and show the thumb
immediately on mount when content overflows, on desktop runtimes.
userIntentOnly consumers (chat auto-follow scroll, reasoning blocks)
keep today's intent-gated behavior unchanged.
- index.css: scope the Settings-specific hide rule to non-desktop, so
mobile/web keep existing behavior and desktop gets the thumb back.
Replace overflow-hidden with overflow-y-scroll on 5 content wrapper divs
so Settings sub-panels (Shortcuts, Plugins, etc.) have an always-visible
vertical scrollbar on both desktop and mobile.
Fixes#2475
