Address review: drop {max} from de/ja tooltips, add isolated-path test

German and Japanese locales (added on main after the original branch point) still interpolated {max}, which would render literally now that the tooltip passes no max param. Also cover the isolated per-worktree dispatch path (>5 models) in the store test.
This commit is contained in:
Tom Rochette
2026-08-13 04:32:15 +00:00
parent c4b14e2a3a
commit f51f77f750
3 changed files with 21 additions and 2 deletions
+1 -1
View File
@@ -347,7 +347,7 @@ export const dict = {
'multirun.launcher.attachments.attach': 'Anhängen',
'multirun.launcher.attachments.tooltip': 'Denselben Dateien an alle Durchläufe senden',
'multirun.launcher.models.label': 'Modelle',
'multirun.launcher.models.info': 'Wählen Sie 2-{max} Modelle. Das gleiche Modell kann mehrfach hinzugefügt werden.',
'multirun.launcher.models.info': 'Wählen Sie 2 oder mehr Modelle. Das gleiche Modell kann mehrfach hinzugefügt werden.',
'multirun.launcher.toast.fileTooLarge': 'Datei "{fileName}" ist zu groß (max. 10MB)',
'multirun.launcher.toast.attachFailed': 'Fehler beim Anhängen von "{fileName}"',
'multirun.launcher.toast.attachedSingle': '{count} Datei angehängt',
+1 -1
View File
@@ -370,7 +370,7 @@ export const dict: Record<I18nKey, string> = {
'multirun.launcher.attachments.attach': '添付',
'multirun.launcher.attachments.tooltip': '同じファイルをすべての実行に送信',
'multirun.launcher.models.label': 'モデル',
'multirun.launcher.models.info': '2{max}モデルを選択。同じモデルを複数回追加できます。',
'multirun.launcher.models.info': '2つ以上のモデルを選択。同じモデルを複数回追加できます。',
'multirun.launcher.toast.fileTooLarge': 'ファイル「{fileName}」が大きすぎます(最大10MB',
'multirun.launcher.toast.attachFailed': '「{fileName}」の添付に失敗しました',
'multirun.launcher.toast.attachedSingle': '{count}ファイルを添付しました',
@@ -242,4 +242,23 @@ describe('useMultiRunStore', () => {
expect(useMultiRunStore.getState().error).toBeNull();
expect(result?.sessionIds).toHaveLength(6);
});
test('accepts more than 5 models on the isolated (per-worktree) dispatch path', async () => {
isGitRepository = true;
const models = Array.from({ length: 6 }, (_, i) => ({
providerID: 'anthropic',
modelID: `claude-sonnet-4-5-${i}`,
}));
const result = await useMultiRunStore.getState().createMultiRun({
name: 'Many models',
isolateRuns: true,
groups: [{ prompt: 'Fix it', models }],
});
expect(useMultiRunStore.getState().error).toBeNull();
expect(result?.sessionIds).toHaveLength(6);
expect(worktreeCreateCalls.length).toBe(6);
});
});